From notifications-return-41829-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org Tue Jan 30 21:29:44 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 3FE1E18061A for ; Tue, 30 Jan 2018 21:29:44 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 2F6EF160C53; Tue, 30 Jan 2018 20:29:44 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 77B1C160C2A for ; Tue, 30 Jan 2018 21:29:43 +0100 (CET) Received: (qmail 35496 invoked by uid 500); 30 Jan 2018 20:29:42 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 35485 invoked by uid 99); 30 Jan 2018 20:29:42 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Jan 2018 20:29:42 +0000 From: GitBox To: notifications@accumulo.apache.org Subject: [GitHub] keith-turner commented on a change in pull request #370: ACCUMULO-4772 Update shell to use NewTableConfiguration methods Message-ID: <151734418201.2335.6909594725970003321.gitbox@gitbox.apache.org> keith-turner commented on a change in pull request #370: ACCUMULO-4772 Update shell to use NewTableConfiguration methods URL: https://github.com/apache/accumulo/pull/370#discussion_r164869308 ########## File path: test/src/main/java/org/apache/accumulo/test/ShellServerIT.java ########## @@ -2020,4 +2022,143 @@ public void testSummarySelection() throws Exception { // check that there are two files, with none having extra summary info assertMatches(output, "(?sm).*^.*total[:]2[,]\\s+missing[:]0[,]\\s+extra[:]0.*$.*"); } + Review comment: Oh I meant tests, all of them together are a good verification of the new options. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services