From notifications-return-41748-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org Thu Jan 25 21:21:41 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 32583180651 for ; Thu, 25 Jan 2018 21:21:41 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 22AD9160C52; Thu, 25 Jan 2018 20:21:41 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6A498160C17 for ; Thu, 25 Jan 2018 21:21:40 +0100 (CET) Received: (qmail 51738 invoked by uid 500); 25 Jan 2018 20:21:39 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 51691 invoked by uid 99); 25 Jan 2018 20:21:39 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Jan 2018 20:21:39 +0000 From: GitBox To: notifications@accumulo.apache.org Subject: [GitHub] ctubbsii commented on a change in pull request #366: ACCUMULO-4779 Speedup Property by precomputing and avoiding sync Message-ID: <151691169902.30177.12037060223792381278.gitbox@gitbox.apache.org> ctubbsii commented on a change in pull request #366: ACCUMULO-4779 Speedup Property by precomputing and avoiding sync URL: https://github.com/apache/accumulo/pull/366#discussion_r163952193 ########## File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java ########## @@ -629,6 +633,11 @@ public String getRawDefaultValue() { * @return default value */ public String getDefaultValue() { + Preconditions.checkState(defaultValueComputed); + return computedDefaultValue; + } + + private void precomputeDefaultValue() { Review comment: I wonder if we can't compute the default value in the constructor? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services