From notifications-return-41609-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org Tue Jan 16 18:49:03 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id EC7CE18066D for ; Tue, 16 Jan 2018 18:49:02 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id DB435160C1D; Tue, 16 Jan 2018 17:49:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 24BF8160C34 for ; Tue, 16 Jan 2018 18:49:01 +0100 (CET) Received: (qmail 30732 invoked by uid 500); 16 Jan 2018 17:49:01 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 30710 invoked by uid 99); 16 Jan 2018 17:49:01 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jan 2018 17:49:01 +0000 From: GitBox To: notifications@accumulo.apache.org Subject: [GitHub] keith-turner commented on a change in pull request #356: ACCUMULO-4777 Removed the unused sequence generator. Message-ID: <151612494062.15271.12383387649699166863.gitbox@gitbox.apache.org> keith-turner commented on a change in pull request #356: ACCUMULO-4777 Removed the unused sequence generator. URL: https://github.com/apache/accumulo/pull/356#discussion_r161834706 ########## File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java ########## @@ -263,13 +263,13 @@ "The maximum size for each write-ahead log. See comment for property tserver.memory.maps.max"), TSERV_WALOG_MAX_AGE("tserver.walog.max.age", "24h", PropertyType.TIMEDURATION, "The maximum age for each write-ahead log."), TSERV_WALOG_TOLERATED_CREATION_FAILURES("tserver.walog.tolerated.creation.failures", "50", PropertyType.COUNT, - "The maximum number of failures tolerated when creating a new WAL file within the period specified by tserver.walog.failures.period." Review comment: These removed docs mention a `tserver.walog.failures.period` prop. I thought I might see something in this PR removing that prop, but did not. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services