accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] keith-turner commented on a change in pull request #366: ACCUMULO-4779 Speedup Property by precomputing and avoiding sync
Date Thu, 01 Jan 1970 00:00:00 GMT
keith-turner commented on a change in pull request #366: ACCUMULO-4779 Speedup Property by
precomputing and avoiding sync
URL: https://github.com/apache/accumulo/pull/366#discussion_r164004925
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
 ##########
 @@ -629,6 +633,11 @@ public String getRawDefaultValue() {
    * @return default value
    */
   public String getDefaultValue() {
+    Preconditions.checkState(defaultValueComputed);
 
 Review comment:
   I think an IllegalStateException is ok.  I changed the code to provide an error message.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message