accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] keith-turner commented on a change in pull request #356: ACCUMULO-4777 Removed the unused sequence generator.
Date Thu, 01 Jan 1970 00:00:00 GMT
keith-turner commented on a change in pull request #356: ACCUMULO-4777 Removed the unused sequence
generator.
URL: https://github.com/apache/accumulo/pull/356#discussion_r161816971
 
 

 ##########
 File path: server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java
 ##########
 @@ -400,24 +406,26 @@ private int write(final Collection<CommitSession> sessions, boolean
mincFinish,
         if (currentLogId == logId.get()) {
 
           // write the mutation to the logs
-          seq = seqGen.incrementAndGet();
-          if (seq < 0)
-            throw new RuntimeException("Logger sequence generator wrapped!  Onos!!!11!eleven");
-          LoggerOperation lop = writer.write(copy, seq);
+          LoggerOperation lop = writer.write(copy);
           lop.await();
 
           // double-check: did the log set change?
           success = (currentLogId == logId.get());
         }
       } catch (DfsLogger.LogClosedException ex) {
-        log.debug("Logs closed while writing, retrying " + attempt);
+        log.debug("Logs closed while writing, retrying attempt " + writeRetry.retriesCompleted());
 
 Review comment:
   So in this case it retries immediately?   This is not related to your fix, but looking
at this I am wondering if it should wait here also.   Need to dig into what throws this exception.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message