Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@apache.org
Date: Fri, 1 Dec 2017 18:28:00 +0000 (UTC)
From: "Keith Turner (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.13119724.1511198383000.366669.1512152880329@Atlassian.JIRA>
In-Reply-To: <JIRA.13119724.1511198383000@Atlassian.JIRA>
References: <JIRA.13119724.1511198383000@Atlassian.JIRA> <JIRA.13119724.1511198383057@jira-lw-us.apache.org>
Subject: [jira] [Assigned] (ACCUMULO-4743) Use tserver prefix for Cache
 config instead of general custom
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 01 Dec 2017 18:28:05 -0000


     [ https://issues.apache.org/jira/browse/ACCUMULO-4743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Keith Turner reassigned ACCUMULO-4743:
--------------------------------------

    Assignee: Jared R

> Use tserver prefix for Cache config instead of general custom
> -------------------------------------------------------------
>
>                 Key: ACCUMULO-4743
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4743
>             Project: Accumulo
>          Issue Type: Bug
>            Reporter: Keith Turner
>            Assignee: Jared R
>              Labels: pull-request-available
>             Fix For: 2.0.0
>
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> In ACCUMULO-4463 caching implementations were made configurable.  At the time config for a cache was placed under the {{general.custom.cache}} prefix.  The idea was that a cache impl would be passed in a AccumuloConfiguration object and it could grab whatever it wanted from {{general.custom.cache}}.  
> In ACCUMULO-4644 the cache API was changed to not use AccumuloConfiguration because that type is not in the public API.  This removed the reason for using general.custom in the first place.
> When trying to implement an external cache I discovered that I can not set general.custom props in zookeeper.  However the cache class is a tserver prefixed property can can be set in zookeeper.  For the [accumulo-ohc|https://github.com/keith-turner/accumulo-ohc] I wanted to do the following in the shell but could not set the general props.
> {noformat}
> config -s general.custom.cache.ohc.data.on-heap.maximumWeight=1000000000
> config -s general.custom.cache.ohc.data.off-heap.capacity=10000000000
> config -s tserver.cache.manager.class=accumulo.ohc.OhcCacheManager
> {noformat}
> I think it would be nice to change cache config prefix from {{general.custom.cache.<scope>.<user prop>}} to {{tserver.cache.config.<scope>.<user prop>}}.  Doing this would enable setting up a cache in the shell like the following.
> {noformat}
> config -s tserver.cache.config.data.on-heap.maximumWeight=1000000000
> config -s tserver.cache.config.data.off-heap.capacity=10000000000
> config -s tserver.cache.manager.class=accumulo.ohc.OhcCacheManager
> {noformat}
> Part of the code for this prefix is at [BlockCacheManager.java line 33|https://github.com/apache/accumulo/blob/d877a2df2943e48d70d99b96616844d0dff9a501/core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCacheManager.java#L33]


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)