accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jared R (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (ACCUMULO-3902) Ensure [Batch]Scanners are closed in ITs
Date Tue, 12 Dec 2017 15:13:00 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287715#comment-16287715
] 

Jared R edited comment on ACCUMULO-3902 at 12/12/17 3:12 PM:
-------------------------------------------------------------

Since I want to try to clean up some older tickets, I will take a look into this. So far I
see that even though ScannerBase extends AutoCloseable some ITs have scanners and/or batchscanners
that aren't in the required try- with-resources block. So I will attempt to rectify this.



was (Author: jkrdev):
Since I want to try to clean up some older tickets, I will take a look into this. So far I
see that even though ScannerBase extends AutoCloseable some ITs aren't in the required tr-
with-resources block. So I will attempt to rectify this. 

> Ensure [Batch]Scanners are closed in ITs
> ----------------------------------------
>
>                 Key: ACCUMULO-3902
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3902
>             Project: Accumulo
>          Issue Type: Bug
>          Components: test
>            Reporter: Josh Elser
>            Assignee: Jared R
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 1.7.4, 1.8.2, 2.0.0
>
>
> Do an audit of the integration tests to verify that we actually close Scanners and BatchScanners.
This is a best practice that we should be encouraging (by doing it in our tests). It can also
lead to bugs in other test cases (ACCUMULO-3888).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message