accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jomach commented on a change in pull request #325: ACCUMULO-2341?
Date Thu, 01 Jan 1970 00:00:00 GMT
jomach commented on a change in pull request #325: ACCUMULO-2341?
URL: https://github.com/apache/accumulo/pull/325#discussion_r154865055
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/client/impl/MasterClient.java
 ##########
 @@ -44,14 +44,14 @@
   public static MasterClientService.Client getConnectionWithRetry(ClientContext context)
{
     while (true) {
 
-      MasterClientService.Client result = getConnection(context);
+      MasterClientService.Client result = getConnection(context, false);
       if (result != null)
         return result;
       sleepUninterruptibly(250, TimeUnit.MILLISECONDS);
     }
   }
 
-  public static MasterClientService.Client getConnection(ClientContext context) {
+  public static MasterClientService.Client getConnection(ClientContext context, boolean isAdminRequest)
{
 
 Review comment:
   Sorry but we agreed on a discussion that we really don't want to have that. The isAdminRequest
will mean that it should not try forever as it is a administration task like shutdown. That's
why we need to differ here. My Initial PR has done exactly that we conclude that what timeout
should then we use  ? That's why we discard that option 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message