accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] ctubbsii commented on a change in pull request #325: ACCUMULO-2341?
Date Thu, 01 Jan 1970 00:00:00 GMT
ctubbsii commented on a change in pull request #325: ACCUMULO-2341?

 File path: core/src/main/java/org/apache/accumulo/core/client/impl/
 @@ -44,14 +44,14 @@
   public static MasterClientService.Client getConnectionWithRetry(ClientContext context)
     while (true) {
-      MasterClientService.Client result = getConnection(context);
+      MasterClientService.Client result = getConnection(context, false);
       if (result != null)
         return result;
       sleepUninterruptibly(250, TimeUnit.MILLISECONDS);
-  public static MasterClientService.Client getConnection(ClientContext context) {
+  public static MasterClientService.Client getConnection(ClientContext context, boolean isAdminRequest)
 Review comment:
   I'm confused about the `isAdminRequest`. The boolean flag should be named based on what
it controls, not what kind of request the caller is going to use it for. In this case, maybe
something like `boolean withTimeout`. Or better yet, pass the timeout in as an integer: `long
timeoutMillis`, and then the `if` statement below becomes `if (timeoutMillis > 0)`

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message