Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@apache.org
From: GitBox <git@apache.org>
To: notifications@accumulo.apache.org
Subject: [GitHub] milleruntime commented on a change in pull request #43: ACCUMULO-4734 Changes from review of tour
Message-ID: <151199563729.31941.16206552761057187354.gitbox@gitbox.apache.org>
archived-at: Wed, 29 Nov 2017 22:47:19 -0000

milleruntime commented on a change in pull request #43: ACCUMULO-4734 Changes from review of tour
URL: https://github.com/apache/accumulo-website/pull/43#discussion_r153938770
 
 
 ##########
 File path: tour/authorizations-code.md
 ##########
 @@ -1,64 +1,69 @@
 ---
 title: Authorizations Code
 ---
+
+Below is a solution for the exercise.
+
 ```java
-        // start writing your code here
-        // Connect to Mini Accumulo as the root user and create a table called "GothamPD".
-        Connector conn = mac.getConnector("root", "tourguide");
-        conn.tableOperations().create("GothamPD");
+static void exercise(MiniAccumuloCluster mac) throws Exception {
+    // Connect to Mini Accumulo as the root user and create a table called "GothamPD".
+    Connector conn = mac.getConnector("root", "tourguide");
+    conn.tableOperations().create("GothamPD");
 
-        // Create a "secretIdentity" authorization & visibility
-        final String secId = "secretIdentity";
-        Authorizations auths = new Authorizations(secId);
-        ColumnVisibility visibility = new ColumnVisibility(secId);
+    // Create a "viewSecretId" authorization & visibility
+    final String viewSecretId = "viewSecretId";
 
 Review comment:
   I like "secretIdentity" better since it applies to both an authorization and visibility.  It seems odd to secure a column with a visibility = "viewSecretId"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services