Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@apache.org
From: GitBox <git@apache.org>
To: notifications@accumulo.apache.org
Subject: [GitHub] milleruntime commented on a change in pull request #326: ACCUMULO-4745 Fixed broken links in tables table on monitor
Message-ID: <151189084957.10357.17335008040447202256.gitbox@gitbox.apache.org>
archived-at: Tue, 28 Nov 2017 17:40:51 -0000

milleruntime commented on a change in pull request #326: ACCUMULO-4745 Fixed broken links in tables table on monitor
URL: https://github.com/apache/accumulo/pull/326#discussion_r153568544
 
 
 ##########
 File path: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/tables/TableInformation.java
 ##########
 @@ -30,7 +29,7 @@
 
   // Variable names become JSON keys
   public String tablename;
-  public Table.ID tableId;
+  public String tableId;
 
 Review comment:
   Could change the variable name, like you did below.  You would probably have to change it on the front end as well though.  You could use tableIdString if the other is too long.  It is just nice to know you are working with a string and not the Table.ID object.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services