Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@apache.org
From: GitBox <git@apache.org>
To: notifications@accumulo.apache.org
Subject: [GitHub] ctubbsii commented on a change in pull request #323: ACCUMULO-4739 Make Monitor resources configurable
Message-ID: <151181619056.23400.9739393002243157823.gitbox@gitbox.apache.org>
archived-at: Mon, 27 Nov 2017 20:56:32 -0000

ctubbsii commented on a change in pull request #323: ACCUMULO-4739 Make Monitor resources configurable
URL: https://github.com/apache/accumulo/pull/323#discussion_r153317791
 
 
 ##########
 File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
 ##########
 @@ -417,6 +417,8 @@
       "The amount of time to sleep between checking for the Montior ZooKeeper lock"),
   MONITOR_LOG_DATE_FORMAT("monitor.log.date.format", "yyyy/MM/dd HH:mm:ss,SSS", PropertyType.STRING, "The SimpleDateFormat string used to configure "
       + "the date shown on the 'Recent Logs' monitor page"),
+  MONITOR_RESOURCES_EXTERNAL("monitor.resources.external", "", PropertyType.STRING,
+      "JSON list of HTML tags of external resources (JS and CSS) to be imported by the Monitor. Be sure to wrap with CDATA tags."),
 
 Review comment:
   I assume the CDATA tag wrapping necessary to avoid the values being interpreted as XML?
   Description could mention that if this is not set, then, the monitor will try to load external resources, such as jquery, bootstrap, etc., from its class path.
   We could put the default ones here instead of handling that in the template, but it'd be ugly. I'm fine with doing it either way, but the description should be updated to mention where it's loading them from when it's not set.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services