Return-Path: <notifications-return-40431-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 17165200D3B
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri, 10 Nov 2017 15:58:21 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 159BF160BEE; Fri, 10 Nov 2017 14:58:21 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 519AC160BCB
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 10 Nov 2017 15:58:20 +0100 (CET)
Received: (qmail 66770 invoked by uid 500); 10 Nov 2017 14:58:19 -0000
Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:notifications-help@accumulo.apache.org>
List-Unsubscribe: <mailto:notifications-unsubscribe@accumulo.apache.org>
List-Post: <mailto:notifications@accumulo.apache.org>
List-Id: <notifications.accumulo.apache.org>
Reply-To: jira@apache.org
Delivered-To: mailing list notifications@accumulo.apache.org
Received: (qmail 66759 invoked by uid 99); 10 Nov 2017 14:58:19 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Nov 2017 14:58:19 +0000
From: GitBox <git@apache.org>
To: notifications@accumulo.apache.org
Subject: [GitHub] keith-turner commented on a change in pull request #321: ACCUMULO-4641 Added loading to cache API
Message-ID: <151032589886.24598.16338927587407904410.gitbox@gitbox.apache.org>
archived-at: Fri, 10 Nov 2017 14:58:21 -0000

keith-turner commented on a change in pull request #321: ACCUMULO-4641 Added loading to cache API
URL: https://github.com/apache/accumulo/pull/321#discussion_r150255263
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/tinylfu/TinyLfuBlockCache.java
 ##########
 @@ -47,7 +47,7 @@
  * <li>Cache design: http://highscalability.com/blog/2016/1/25/design-of-a-modern-cache.html</li>
  * </ul>
  */
-public final class TinyLfuBlockCache implements BlockCache {
+public final class TinyLfuBlockCache extends SynchronousLoadingBlockCache implements BlockCache {
 
 Review comment:
   Thanks for sharing.  That is exactly the type of information I was looking for when spelunking in the Caffeine code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services