Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@apache.org
From: GitBox <git@apache.org>
To: notifications@accumulo.apache.org
Subject: [GitHub] keith-turner commented on a change in pull request #319: ACCUMULO-4737 Clean up cipher algorithm configuration
Message-ID: <151007702812.29255.18297550110701034157.gitbox@gitbox.apache.org>
archived-at: Tue, 07 Nov 2017 17:50:30 -0000

keith-turner commented on a change in pull request #319: ACCUMULO-4737 Clean up cipher algorithm configuration
URL: https://github.com/apache/accumulo/pull/319#discussion_r149447988
 
 
 ##########
 File path: core/src/main/java/org/apache/accumulo/core/security/crypto/CryptoModuleFactory.java
 ##########
 @@ -239,14 +239,6 @@ public CryptoModuleParameters initializeCipher(CryptoModuleParameters params) {
 
   }
 
-  public static String[] parseCipherTransform(String cipherTransform) {
-    if (cipherTransform == null) {
-      return new String[3];
-    }
-
-    return cipherTransform.split("/");
 
 Review comment:
   This parsing was bad, it did no validation.  It seems like this changes removes all custom parsing and uses java standard libs to do the parsing, is this correct?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services