accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Updated] (ACCUMULO-4743) Use tserver prefix for Cache config instead of general custom
Date Wed, 29 Nov 2017 16:38:00 GMT


ASF GitHub Bot updated ACCUMULO-4743:
    Labels: pull-request-available  (was: )

> Use tserver prefix for Cache config instead of general custom
> -------------------------------------------------------------
>                 Key: ACCUMULO-4743
>                 URL:
>             Project: Accumulo
>          Issue Type: Bug
>            Reporter: Keith Turner
>              Labels: pull-request-available
>             Fix For: 2.0.0
> In ACCUMULO-4463 caching implementations were made configurable.  At the time config
for a cache was placed under the {{general.custom.cache}} prefix.  The idea was that a cache
impl would be passed in a AccumuloConfiguration object and it could grab whatever it wanted
from {{general.custom.cache}}.  
> In ACCUMULO-4644 the cache API was changed to not use AccumuloConfiguration because that
type is not in the public API.  This removed the reason for using general.custom in the first
> When trying to implement an external cache I discovered that I can not set general.custom
props in zookeeper.  However the cache class is a tserver prefixed property can can be set
in zookeeper.  For the [accumulo-ohc|] I wanted
to do the following in the shell but could not set the general props.
> {noformat}
> config -s
> config -s
> config -s tserver.cache.manager.class=accumulo.ohc.OhcCacheManager
> {noformat}
> I think it would be nice to change cache config prefix from {{general.custom.cache.<scope>.<user
prop>}} to {{tserver.cache.config.<scope>.<user prop>}}.  Doing this would
enable setting up a cache in the shell like the following.
> {noformat}
> config -s
> config -s
> config -s tserver.cache.manager.class=accumulo.ohc.OhcCacheManager
> {noformat}
> Part of the code for this prefix is at [ line 33|]

This message was sent by Atlassian JIRA

View raw message