accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ctubbsii commented on a change in pull request #326: ACCUMULO-4745 Fixed broken links in tables table on monitor
Date Thu, 01 Jan 1970 00:00:00 GMT
ctubbsii commented on a change in pull request #326: ACCUMULO-4745 Fixed broken links in tables
table on monitor
URL: https://github.com/apache/accumulo/pull/326#discussion_r153630572
 
 

 ##########
 File path: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/tables/TablesResource.java
 ##########
 @@ -112,6 +112,7 @@ private static TablesList generateTables(TablesList tableNamespace) {
     for (Entry<String,Table.ID> entry : Tables.getNameToIdMap(HdfsZooInstance.getInstance()).entrySet())
{
       String tableName = entry.getKey();
       Table.ID tableId = entry.getValue();
+      String canonicalTableId = tableId.canonicalID();
 
 Review comment:
   I was thinking this could be deferred to the constructors of `TableInformation`; that way,
this class wouldn't need to change at all, and we can keep the `Table.ID` object around as
long as possible before it is serialized in `TableInformation`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message