accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] keith-turner commented on a change in pull request #327: ACCUMULO-4546 Create default log message for IllegalTableTransitionException
Date Thu, 01 Jan 1970 00:00:00 GMT
keith-turner commented on a change in pull request #327: ACCUMULO-4546 Create default log message
for IllegalTableTransitionException
URL: https://github.com/apache/accumulo/pull/327#discussion_r153531488
 
 

 ##########
 File path: server/base/src/main/java/org/apache/accumulo/server/tables/TableManager.java
 ##########
 @@ -115,10 +115,21 @@ public TableState getTableState(String tableId) {
 
     final TableState oldState;
     final TableState newState;
+    final String message;
 
     public IllegalTableTransitionException(TableState oldState, TableState newState) {
+      this(oldState, newState, "");
+    }
+
+    public IllegalTableTransitionException(TableState oldState, TableState newState, String
message) {
       this.oldState = oldState;
       this.newState = newState;
+
+      String defaultMessage = "Error transitioning from " + oldState + " state to " + newState
+ " state";
 
 Review comment:
   Could this be moved inside the else block?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message