accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ctubbsii commented on a change in pull request #289: ACCUMULO-4677 Sanitizing PathParam values in REST-based Monitor
Date Thu, 01 Jan 1970 00:00:00 GMT
ctubbsii commented on a change in pull request #289: ACCUMULO-4677 Sanitizing PathParam values
in REST-based Monitor
URL: https://github.com/apache/accumulo/pull/289#discussion_r153364007
 
 

 ##########
 File path: server/monitor/src/test/java/org/apache/accumulo/monitor/view/WebViewsTest.java
 ##########
 @@ -130,6 +130,7 @@ public void testGetTracesSummaryValidationConstraint() {
   /**
    * Silly stub to handle MessageBodyWriter for Hashmap. Registered in configure method and
auto-wired by Jersey.
    */
+  @SuppressWarnings("rawtypes")
 
 Review comment:
   `<?,?>` as the generic type would be much preferred over suppressing the warning.
It's always better to be explicit, and I'm not a fan of instructing the compiler to ignore
warnings when there's an easy fix.
   
   Also, I just noticed that this test creates an external web service to test against. As
such, this test should be renamed to be `WebViewsIT`, because it's an integration test, and
not just a unit test.
   
   And, don't worry about the conflicts with master. I can take care of that for you (going
to rebase before merge). I can also address these last few minor issues, too, during the rebase/merge
process.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message