accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ctubbsii commented on a change in pull request #326: ACCUMULO-4745 Fixed broken links in tables table on monitor
Date Thu, 01 Jan 1970 00:00:00 GMT
ctubbsii commented on a change in pull request #326: ACCUMULO-4745 Fixed broken links in tables
table on monitor
URL: https://github.com/apache/accumulo/pull/326#discussion_r153311907
 
 

 ##########
 File path: server/monitor/src/main/resources/resources/js/tables.js
 ##########
 @@ -184,7 +184,7 @@ function populateTable(ns) {
 
         var row = [];
         row.push(createFirstCell(val.tablename,
-            '<a href="/tables/' + val.tableId + '">' + val.tablename + '</a>'));
+            '<a href="/tables/' + atob(val.tableId.utf8) + '">' + val.tablename + '</a>'));
 
 Review comment:
   Good find! While this is one possible workaround, I think the core of this problem is actually
that the Table.ID object is being stored in the first place. I think the real problem is that
`org.apache.accumulo.monitor.rest.tables.TableInformation` is storing a `Table.ID` instead
of its canonical string. Since the point of this class is to create a serialized version of
the table id, I think it should store it as a String in that class. Fixing it there, will
also fix the JSON objects in the REST calls, wherever it is used, rather than just in this
code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message