accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] keith-turner commented on a change in pull request #322: ACCUMULO-4740 Enable GCM mode for crypto
Date Thu, 01 Jan 1970 00:00:00 GMT
keith-turner commented on a change in pull request #322: ACCUMULO-4740 Enable GCM mode for
crypto
URL: https://github.com/apache/accumulo/pull/322#discussion_r152382316
 
 

 ##########
 File path: core/src/test/java/org/apache/accumulo/core/security/crypto/CryptoTest.java
 ##########
 @@ -357,14 +363,209 @@ public void testKeyWrapAndUnwrap() throws NoSuchAlgorithmException,
NoSuchPaddin
     byte[] wrappedKey = keyWrapCipher.wrap(randKey);
 
     assert (wrappedKey != null);
-    assert (wrappedKey.length == randomKey.length);
+    // AESWrap will produce 24 bytes given 128 bits of key data with a 128-bit KEK
+    assert (wrappedKey.length == randomKey.length + 8);
 
 Review comment:
   I think these are calls are using the java assert statement which by default does nothing.
 Java assertions have to be turned on.  Should use the junit assertTrue method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message