accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ctubbsii commented on a change in pull request #323: ACCUMULO-4739 Make Monitor resources configurable
Date Thu, 01 Jan 1970 00:00:00 GMT
ctubbsii commented on a change in pull request #323: ACCUMULO-4739 Make Monitor resources configurable
URL: https://github.com/apache/accumulo/pull/323#discussion_r151796430
 
 

 ##########
 File path: server/monitor/pom.xml
 ##########
 @@ -137,7 +137,13 @@
           <artifactId>apache-rat-plugin</artifactId>
           <configuration>
             <excludes>
-              <exclude>src/main/resources/resources/js/flot/**/*.js</exclude>
+              <exclude>src/main/resources/org/apache/accumulo/monitor/js/flot/*.js</exclude>
 
 Review comment:
   Would it make sense to simplify this by excluding everything like src/main/resources/org/apache/accumulo/monitor/**/*.js
and src/main/resources/org/apache/accumulo/monitor/**/*.css ?
   
   Could also put these in a subdirectory called "third-party" or something to make the pattern
easier, and to organize it away from our custom js and css files.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message