accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ctubbsii commented on a change in pull request #319: ACCUMULO-4737 Clean up cipher algorithm configuration
Date Thu, 01 Jan 1970 00:00:00 GMT
ctubbsii commented on a change in pull request #319: ACCUMULO-4737 Clean up cipher algorithm
configuration
URL: https://github.com/apache/accumulo/pull/319#discussion_r149515648
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
 ##########
 @@ -48,10 +48,18 @@
       "Fully qualified class name of the class that implements the CryptoModule interface,
to be used in setting up encryption at rest for the WAL and "
           + "(future) other parts of the code."),
   @Experimental
-  CRYPTO_CIPHER_SUITE("crypto.cipher.suite", "NullCipher", PropertyType.STRING, "Describes
the cipher suite to use for the write-ahead log"),
+  CRYPTO_CIPHER_SUITE("crypto.cipher.suite", "NullCipher", PropertyType.STRING,
 
 Review comment:
   This property existed before. This PR only improves this property's description. If we
actually change the property, I'm thinking we should change it to a per-table setting also
(along with other crypto properties). I wouldn't want to see us change it once, only to change
it again a second time to make it per-table. Could do both at once in a follow-on task.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message