accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] mikewalch commented on a change in pull request #316: ACCUMULO-4706 Updates to support Accumulo docker image
Date Thu, 01 Jan 1970 00:00:00 GMT
mikewalch commented on a change in pull request #316: ACCUMULO-4706 Updates to support Accumulo
docker image
URL: https://github.com/apache/accumulo/pull/316#discussion_r148308517
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/conf/SiteConfiguration.java
 ##########
 @@ -119,8 +119,15 @@ synchronized private static Configuration getXmlConfig() {
 
   @Override
   public String get(Property property) {
-    String key = property.getKey();
+    return get(property, true);
+  }
 
+  public String get(Property property, boolean useDefault) {
 
 Review comment:
   I want anything set on the command line (i.e CliConfig) to override SiteConfg so I don't
know a layer between SiteConfig & DefaultConfig makes sense

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message