Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9B947200D1E for ; Wed, 18 Oct 2017 23:24:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9A252160BEA; Wed, 18 Oct 2017 21:24:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D713A1609DE for ; Wed, 18 Oct 2017 23:24:09 +0200 (CEST) Received: (qmail 53964 invoked by uid 500); 18 Oct 2017 21:24:09 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 53952 invoked by uid 99); 18 Oct 2017 21:24:09 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Oct 2017 21:24:09 +0000 From: GitBox To: notifications@accumulo.apache.org Subject: [GitHub] ctubbsii commented on a change in pull request #7: ACCUMULO-4717 Use public API Message-ID: <150836184848.11713.8295576077243370100.gitbox@gitbox.apache.org> archived-at: Wed, 18 Oct 2017 21:24:10 -0000 ctubbsii commented on a change in pull request #7: ACCUMULO-4717 Use public API URL: https://github.com/apache/accumulo-testing/pull/7#discussion_r145547456 ########## File path: core/src/main/java/org/apache/accumulo/testing/core/randomwalk/shard/BulkInsert.java ########## @@ -172,7 +171,7 @@ private void sort(State state, RandWalkEnv env, FileSystem fs, String tableName, Collection splits = conn.tableOperations().listSplits(tableName, maxSplits); for (Text split : splits) - out.println(Base64.getEncoder().encodeToString(TextUtil.getBytes(split))); + out.println(Base64.getEncoder().encodeToString(split.getBytes())); Review comment: Well, ideally, Text will not be part of the API, eventually. It might make sense to move a few helpful utils into the public API in the interim. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services