accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Piotr Findeisen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-4701) Shade Guava dependency
Date Mon, 11 Sep 2017 15:45:00 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-4701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16161462#comment-16161462
] 

Piotr Findeisen commented on ACCUMULO-4701:
-------------------------------------------

bq. For 1.7.4 and 1.8.2 we maintain the same version of Guava but avoid using methods that
don't exists in current Guava.

[~kturner], that will probably work. Of course, you can also upgrade the dependency in minor
releases (assuming Guava is internal and pretty stable, it shouldn't require a major release
to bump Guava dependency). Simply upgrading might be simply easier :)

BTW {{@Beta}} has class file retention. Do you know static analysis tool that could report
such usages?

bq. I did some quick searches on the code and we only have 28 occurrences of getHostText()
in 1.7. \[...] I don't know if this well help your problem Piotr Findeisen 

[~milleruntime], I don't know either. This is the method I found, but I wasn't using source
(only jar), so it was a bit harder to check for others. Probably simplest way to check that
is locally bumping Guava dependency and making sure code still compiles. (I know this is only
an approximation of a formally correct process, but a good one.)


> Shade Guava dependency
> ----------------------
>
>                 Key: ACCUMULO-4701
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4701
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 1.7.3
>            Reporter: Piotr Findeisen
>            Assignee: Christopher Tubbs
>
> [{{presto-accumulo}}|https://github.com/prestodb/presto/tree/master/presto-accumulo]
connector embeds Accumulo client {{org.apache.accumulo:accumulo-core}}. Accumulo uses Guava.
Since Guava APIs are not strictly backwards compatible, it's necessary to shade guava dependency
or library users need to use same Guava version (i.e. cannot upgrade/downgrade at will).
> Please shade Guava dependency.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message