Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@apache.org
Date: Fri, 21 Jul 2017 02:50:00 +0000 (UTC)
From: "Christopher Tubbs (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.13088949.1500605309000.298857.1500605400074@Atlassian.JIRA>
In-Reply-To: <JIRA.13088949.1500605309000@Atlassian.JIRA>
References: <JIRA.13088949.1500605309000@Atlassian.JIRA> <JIRA.13088949.1500605309817@jira-lw-us.apache.org>
Subject: [jira] [Updated] (ACCUMULO-4682) Standardize and enforce import
 order
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 21 Jul 2017 02:50:16 -0000


     [ https://issues.apache.org/jira/browse/ACCUMULO-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christopher Tubbs updated ACCUMULO-4682:
----------------------------------------
    Component/s: build

> Standardize and enforce import order
> ------------------------------------
>
>                 Key: ACCUMULO-4682
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4682
>             Project: Accumulo
>          Issue Type: Task
>          Components: build
>            Reporter: Christopher Tubbs
>            Assignee: Christopher Tubbs
>             Fix For: 1.7.4, 1.8.2, 2.0.0
>
>
> I created a plugin to automatically format Java source files with import order rules.
> I ran and tested it on Accumulo and it worked well, aside from a few malformed files.
> http://code.revelc.net/impsort-maven-plugin/sort-mojo.html
> https://github.com/revelc/impsort-maven-plugin
> (NOTE: each group is sorted within its section)
> I tested using Eclipse default import order rules, which are:
> {code}
> static *
> java.*
> javax.*
> org.*
> com.*
> * - everything else
> {code}
> These are a bit unnecessary, I think. A saner and more useful ordering might be:
> {code}
> static *
> org.apache.accumulo.*
> java.*
> javax.*
> * - everything else
> {code}
> Alternatively, I do like the simplicity of:
> {code}
> static *
> (with or without blank line?)
> * - everything else
> {code}
> The plugin can handle any of these, so we just need to pick what we like.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)