accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-4682) Standardize and enforce import order
Date Tue, 25 Jul 2017 20:53:00 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100761#comment-16100761
] 

Christopher Tubbs commented on ACCUMULO-4682:
---------------------------------------------

Given the lack of comments, I'm going to go with the minimal change, which is to apply the
Eclipse default rules.

> Standardize and enforce import order
> ------------------------------------
>
>                 Key: ACCUMULO-4682
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4682
>             Project: Accumulo
>          Issue Type: Task
>          Components: build
>            Reporter: Christopher Tubbs
>            Assignee: Christopher Tubbs
>             Fix For: 1.7.4, 1.8.2, 2.0.0
>
>
> I created a plugin to automatically format Java source files with import order rules.
> I ran and tested it on Accumulo and it worked well, aside from a few malformed files.
> http://code.revelc.net/impsort-maven-plugin/sort-mojo.html
> https://github.com/revelc/impsort-maven-plugin
> (NOTE: each group is sorted within its section)
> I tested using Eclipse default import order rules, which are:
> {code}
> static *
> java.*
> javax.*
> org.*
> com.*
> * - everything else
> {code}
> These are a bit unnecessary, I think. A saner and more useful ordering might be:
> {code}
> static *
> org.apache.accumulo.*
> java.*
> javax.*
> * - everything else
> {code}
> Alternatively, I do like the simplicity of:
> {code}
> static *
> (with or without blank line?)
> * - everything else
> {code}
> The plugin can handle any of these, so we just need to pick what we like.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message