Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 10405200C67 for ; Mon, 15 May 2017 23:30:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 0EDDE160BA9; Mon, 15 May 2017 21:30:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5A4BE160BC2 for ; Mon, 15 May 2017 23:30:09 +0200 (CEST) Received: (qmail 97199 invoked by uid 500); 15 May 2017 21:30:07 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 96647 invoked by uid 99); 15 May 2017 21:30:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 May 2017 21:30:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id DA94418913A for ; Mon, 15 May 2017 21:30:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id CwCAAlvoYyr9 for ; Mon, 15 May 2017 21:30:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E45705FCB9 for ; Mon, 15 May 2017 21:30:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 65B5AE0BCD for ; Mon, 15 May 2017 21:30:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 9A40F243BD for ; Mon, 15 May 2017 21:30:04 +0000 (UTC) Date: Mon, 15 May 2017 21:30:04 +0000 (UTC) From: "Josh Elser (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (ACCUMULO-4634) MockIteratorEnvironment implementation broken in mock accumulo framework MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 15 May 2017 21:30:10 -0000 [ https://issues.apache.org/jira/browse/ACCUMULO-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser resolved ACCUMULO-4634. ---------------------------------- Resolution: Fixed Thanks for the patch, Ivan! > MockIteratorEnvironment implementation broken in mock accumulo framework > ------------------------------------------------------------------------ > > Key: ACCUMULO-4634 > URL: https://issues.apache.org/jira/browse/ACCUMULO-4634 > Project: Accumulo > Issue Type: Bug > Components: core > Affects Versions: 1.8.0 > Reporter: Ivan Bella > Assignee: Ivan Bella > Labels: mock > Fix For: 1.8.2, 2.0.0 > > Original Estimate: 1h > Time Spent: 1.5h > Remaining Estimate: 0h > > The MockIteratorEnvironment was broken when the additional sampling methods were added. The isSamplingEnabled throws an unsupported operation exception instead of simply returning false. Also the getSamplerConfiguration should return null and the cloneWithSamplingEnabled should throw a SampleNotPresentException instead an UnsupportedOperationException per the documentation in the IteratorEnvironment interface. This will allow its use to work smoothly as before. Granted this whole MockAccumulo mechanism is deprecated, however external projects still have dependencies on it and hence we should not have broken its implementation. -- This message was sent by Atlassian JIRA (v6.3.15#6346)