accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Miller (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3521) Unused Iterator-related classes
Date Tue, 02 May 2017 20:19:04 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993653#comment-15993653
] 

Michael Miller commented on ACCUMULO-3521:
------------------------------------------

[~dlmarion] I didn't remove anything.  I added tests and did some cleanup to FirstEntryInRowIterator
and TypedValueCombiner. See https://github.com/apache/accumulo/pull/237/files

I also added a test for StatsCombiner in https://github.com/apache/accumulo-examples

> Unused Iterator-related classes
> -------------------------------
>
>                 Key: ACCUMULO-3521
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3521
>             Project: Accumulo
>          Issue Type: Sub-task
>            Reporter: Christopher Tubbs
>            Assignee: Michael Miller
>             Fix For: 2.0.0
>
>          Time Spent: 4.5h
>  Remaining Estimate: 0h
>
> The following iterators and iterator-related utilities have no references at all in our
code; minimally, they should have unit tests (this list does not include deprecated iterators):
> # OrIterator
> # FirstEntryInRowIterator (especially setNumScansBeforeSeek method is never called)
> # TypedValueCombiner (especially setLossyness method is never called)
> # IteratorUtil.getMaxPriority and .findIterator methods
> # StatsCombiner (available in the examples) does not use the setRadix method
> Note: these iterators may not be considered "public API", but might still be unsafe to
remove the unused portions if somebody had used them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message