Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 492BD200C1A for ; Mon, 13 Feb 2017 20:05:48 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 47D02160B6F; Mon, 13 Feb 2017 19:05:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 902D5160B4A for ; Mon, 13 Feb 2017 20:05:47 +0100 (CET) Received: (qmail 8805 invoked by uid 500); 13 Feb 2017 19:05:46 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 8793 invoked by uid 99); 13 Feb 2017 19:05:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Feb 2017 19:05:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 10C391A7AFF for ; Mon, 13 Feb 2017 19:05:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.199 X-Spam-Level: X-Spam-Status: No, score=-1.199 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id tA42WXyxhROZ for ; Mon, 13 Feb 2017 19:05:45 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 1888A5F36E for ; Mon, 13 Feb 2017 19:05:45 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E6428E023B for ; Mon, 13 Feb 2017 19:05:41 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 9AB1821D64 for ; Mon, 13 Feb 2017 19:05:41 +0000 (UTC) Date: Mon, 13 Feb 2017 19:05:41 +0000 (UTC) From: "Christopher Tubbs (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ACCUMULO-4586) Make rowiterator fail when unsorted data is observed MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 13 Feb 2017 19:05:48 -0000 [ https://issues.apache.org/jira/browse/ACCUMULO-4586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864219#comment-15864219 ] Christopher Tubbs commented on ACCUMULO-4586: --------------------------------------------- Currently, {{RowIterator}} provides grouping in the same way that Linux command {{uniq}} provides grouping. That is to say, it only groups adjacent items which match, rather than group all matching items in the stream. I think that, just like for {{uniq}}, partial groupings on unsorted data is still a valid use case. The proposed "fix" removes a perfectly valid use of {{RowIterator}}, changing the behavior to favor a different use case. This is exactly the kind of thing we complain about Thrift doing, as in THRIFT-1805. I don't consider the current behavior to be a bug, but I do recognize that it is prone to being used incorrectly, or with invalid assumptions. Rather than change the behavior of the existing API to accommodate a subset of use cases, I would prefer a new, alternate API to replace it, which imposes the desired restrictions. > Make rowiterator fail when unsorted data is observed > ---------------------------------------------------- > > Key: ACCUMULO-4586 > URL: https://issues.apache.org/jira/browse/ACCUMULO-4586 > Project: Accumulo > Issue Type: Bug > Affects Versions: 1.6.6, 1.7.1, 1.8.0 > Reporter: Keith Turner > Fix For: 2.0.0 > > > A batchscanner was used as a row iterator data source. The rowiterator expects data in sorted order and the batch scanner does not supply data in sorted order. The row iterator should have a sanity check to ensure source data is in sorted order. > https://lists.apache.org/thread.html/c24448d171d8414321bccfc778c7fc8b53e45892cae9daafa220503f@%3Cuser.accumulo.apache.org%3E -- This message was sent by Atlassian JIRA (v6.3.15#6346)