accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Turner (JIRA)" <>
Subject [jira] [Commented] (ACCUMULO-4586) Make rowiterator fail when unsorted data is observed
Date Mon, 13 Feb 2017 22:18:41 GMT


Keith Turner commented on ACCUMULO-4586:

The proposed "fix" removes a perfectly valid use of RowIterator, changing the behavior to
favor a different use case.

I looked at the javadoc for RowIterator and it does not specify that sorted data is expected.
 Therefore using it with unsorted data may be a valid use case.  If someone were relying on
that behavior, I would not want to change the behavior in a bug fix release.  

I still want to help users who are unaware of all of these subtleties in some way.  At the
very least we can improve the javadocs for now to make the potential issues with the batch
scanner clear.

I would prefer a new, alternate API to replace it, which imposes the desired restrictions.

Could introduce a new class in 2.0 and deprecate the current one.  The new class could have
javadocs and strict checks for sorted order.  The new class could possibly be an Iterable
instead of Iterator.

> Make rowiterator fail when unsorted data is observed
> ----------------------------------------------------
>                 Key: ACCUMULO-4586
>                 URL:
>             Project: Accumulo
>          Issue Type: Bug
>    Affects Versions: 1.6.6, 1.7.1, 1.8.0
>            Reporter: Keith Turner
>             Fix For: 2.0.0
> A batchscanner was used as a row iterator data source.  The rowiterator expects data
in sorted order and the batch scanner does not supply data in sorted order.  The row iterator
should have a sanity check to ensure source data is in sorted order.

This message was sent by Atlassian JIRA

View raw message