accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <>
Subject [jira] [Commented] (ACCUMULO-4456) Fix exclusion on answering RPCs when lock is not acquired
Date Wed, 22 Feb 2017 19:14:44 GMT


Josh Elser commented on ACCUMULO-4456:

bq. I'm not sure I fully understand what the replication service is doing, but it's possibly

bq. There's no reason that the replication thrift server should be any different than the

Again, I don't know why it would be different than the others.

bq. There seem to be 3 layers of service wrappers here

    ReplicationCoordinator.Iface haReplicationProxy = HighlyAvailableServiceWrapper.service(impl,
    ReplicationCoordinator.Processor<ReplicationCoordinator.Iface> replicationCoordinatorProcessor
= new ReplicationCoordinator.Processor<>(RpcWrapper.service(
        impl, new ReplicationCoordinator.Processor<>(haReplicationProxy)));

This is what you're referring to? Specifically 

RpcWrapper.service(impl, new ReplicationCoordinator.Processor<>(haReplicationProxy))

Not being 

RpcWrapper.service(haReplicationProxy, new ReplicationCoordinator.Processor<>(haReplicationProxy))

This sounds exactly like the kind of unintentional omission I meant earlier. The change
makes sense.

> Fix exclusion on answering RPCs when lock is not acquired
> ---------------------------------------------------------
>                 Key: ACCUMULO-4456
>                 URL:
>             Project: Accumulo
>          Issue Type: Sub-task
>          Components: client, master
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>             Fix For: 2.0.0
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
> [~kturner] asked me a good question about what the client does when it tries to talk
to a master which has recently lost its active status, how does the client handle the thrown
> Should run a quick local test.

This message was sent by Atlassian JIRA

View raw message