accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-4549) Remove duplicate init functions in TabletBalancer
Date Wed, 11 Jan 2017 22:17:16 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15819350#comment-15819350
] 

Christopher Tubbs commented on ACCUMULO-4549:
---------------------------------------------

I'm deprecating in 1.7.3 and 1.8.1, and removing in 2.0.0/master branch.

> Remove duplicate init functions in TabletBalancer
> -------------------------------------------------
>
>                 Key: ACCUMULO-4549
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4549
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Adam J Shook
>            Assignee: Christopher Tubbs
>            Priority: Minor
>              Labels: release_notes
>             Fix For: 1.7.3, 1.8.1, 2.0.0
>
>
> There are two {{init}} functions with similar signatures in the {{TabletLoadBalancer}}
class that could result in an end-user overriding the wrong function and their object may
never be initialized.
> {{Master}} (1) calls the {{TabletBalancer#init(ServerConfigurationFactory)}} which is
not what the regex load balancer is overriding (2), and the {{TabletBalancer}} doesn't call
the other init function (3).
> Come up with a plan for compatibility and remove the duplicate functions.
> (1) https://github.com/apache/accumulo/blob/1.7/server/master/src/main/java/org/apache/accumulo/master/Master.java#L589
> (2) https://github.com/apache/accumulo/blob/1.7/server/base/src/main/java/org/apache/accumulo/server/master/balancer/HostRegexTableLoadBalancer.java#L257
> (3) https://github.com/apache/accumulo/blob/1.7/server/base/src/main/java/org/apache/accumulo/server/master/balancer/TabletBalancer.java#L57



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message