accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-4510) Accumulo test benchmarks should go in a separate git repo
Date Wed, 25 Jan 2017 16:37:26 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838073#comment-15838073
] 

ASF GitHub Bot commented on ACCUMULO-4510:
------------------------------------------

Github user mikewalch commented on a diff in the pull request:

    https://github.com/apache/accumulo-testing/pull/2#discussion_r97820268
  
    --- Diff: core/src/main/java/org/apache/accumulo/testing/core/continuous/ContinuousIngest.java
---
    @@ -183,8 +177,9 @@ private static long flush(BatchWriter bw, long count, final int flushInterval,
l
         return lastFlushTime;
       }
     
    -  public static Mutation genMutation(long rowLong, int cfInt, int cqInt, ColumnVisibility
cv, byte[] ingestInstanceId, long count, byte[] prevRow, Random r,
    -      boolean checksum) {
    +  static Mutation genMutation(long rowLong, int cfInt, int cqInt, ColumnVisibility cv,
    --- End diff --
    
    I plan on adding the java formatter plugin in a later pull request.


> Accumulo test benchmarks should go in a separate git repo
> ---------------------------------------------------------
>
>                 Key: ACCUMULO-4510
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4510
>             Project: Accumulo
>          Issue Type: Task
>            Reporter: Christopher Tubbs
>            Assignee: Mike Walch
>            Priority: Minor
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Benchmarks should be version-independent, and/or work across versions to be meaningful.
The tests/benchmark scripts which accompany Accumulo releases are also not necessarily tested
or even functional. They should be shipped separately, if we continue to maintain them at
all. I actually don't even think they need to be released. They can be continuously updated
as needed for developer testing/benchmarking, without necessarily releasing (similar with
examples, and website documentation).
> We can request a new git repo easily at https://reporeq.apache.org



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message