accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-4510) Accumulo test benchmarks should go in a separate git repo
Date Wed, 25 Jan 2017 15:57:26 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837962#comment-15837962
] 

ASF GitHub Bot commented on ACCUMULO-4510:
------------------------------------------

Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo-testing/pull/2#discussion_r97806863
  
    --- Diff: core/src/main/java/org/apache/accumulo/testing/core/continuous/ContinuousIngest.java
---
    @@ -51,49 +46,44 @@
     
       private static List<ColumnVisibility> visibilities;
     
    -  private static void initVisibilities(ContinuousOpts opts) throws Exception {
    -    if (opts.visFile == null) {
    -      visibilities = Collections.singletonList(new ColumnVisibility());
    -      return;
    -    }
    -
    -    visibilities = new ArrayList<>();
    -
    -    FileSystem fs = FileSystem.get(new Configuration());
    -    BufferedReader in = new BufferedReader(new InputStreamReader(fs.open(new Path(opts.visFile)),
UTF_8));
    -
    -    String line;
    -
    -    while ((line = in.readLine()) != null) {
    -      visibilities.add(new ColumnVisibility(line));
    -    }
    -
    -    in.close();
    -  }
    -
       private static ColumnVisibility getVisibility(Random rand) {
         return visibilities.get(rand.nextInt(visibilities.size()));
       }
     
       public static void main(String[] args) throws Exception {
     
    -    ContinuousOpts opts = new ContinuousOpts();
    -    BatchWriterOpts bwOpts = new BatchWriterOpts();
    -    ClientOnDefaultTable clientOpts = new ClientOnDefaultTable("ci");
    -    clientOpts.parseArgs(ContinuousIngest.class.getName(), args, bwOpts, opts);
    +    if (args.length != 1) {
    +      System.err.println("Usage: ContinuousIngest <propsPath>");
    --- End diff --
    
    this is nice, replacing all of the command line options with a props file


> Accumulo test benchmarks should go in a separate git repo
> ---------------------------------------------------------
>
>                 Key: ACCUMULO-4510
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4510
>             Project: Accumulo
>          Issue Type: Task
>            Reporter: Christopher Tubbs
>            Assignee: Mike Walch
>            Priority: Minor
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Benchmarks should be version-independent, and/or work across versions to be meaningful.
The tests/benchmark scripts which accompany Accumulo releases are also not necessarily tested
or even functional. They should be shipped separately, if we continue to maintain them at
all. I actually don't even think they need to be released. They can be continuously updated
as needed for developer testing/benchmarking, without necessarily releasing (similar with
examples, and website documentation).
> We can request a new git repo easily at https://reporeq.apache.org



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message