accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-4510) Accumulo test benchmarks should go in a separate git repo
Date Wed, 25 Jan 2017 15:57:26 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837958#comment-15837958
] 

ASF GitHub Bot commented on ACCUMULO-4510:
------------------------------------------

Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo-testing/pull/2#discussion_r97809185
  
    --- Diff: core/src/main/java/org/apache/accumulo/testing/core/continuous/ContinuousScanner.java
---
    @@ -20,49 +20,44 @@
     
     import java.util.Iterator;
     import java.util.Map.Entry;
    +import java.util.Properties;
     import java.util.Random;
     import java.util.concurrent.TimeUnit;
     
    -import org.apache.accumulo.core.cli.ClientOnDefaultTable;
    -import org.apache.accumulo.core.cli.ScannerOpts;
     import org.apache.accumulo.core.client.Connector;
     import org.apache.accumulo.core.client.Scanner;
     import org.apache.accumulo.core.data.Key;
     import org.apache.accumulo.core.data.Range;
     import org.apache.accumulo.core.data.Value;
     import org.apache.accumulo.core.security.Authorizations;
    +import org.apache.accumulo.testing.core.TestProps;
     import org.apache.hadoop.io.Text;
     
    -import com.beust.jcommander.Parameter;
    -import com.beust.jcommander.validators.PositiveInteger;
     import static com.google.common.util.concurrent.Uninterruptibles.sleepUninterruptibly;
     
     public class ContinuousScanner {
     
    -  static class Opts extends ContinuousWalk.Opts {
    -    @Parameter(names = "--numToScan", description = "Number rows to scan between sleeps",
required = true, validateWith = PositiveInteger.class)
    -    long numToScan = 0;
    -  }
    -
       public static void main(String[] args) throws Exception {
    -    Opts opts = new Opts();
    -    ScannerOpts scanOpts = new ScannerOpts();
    -    ClientOnDefaultTable clientOpts = new ClientOnDefaultTable("ci");
    -    clientOpts.parseArgs(ContinuousScanner.class.getName(), args, scanOpts, opts);
    +
    +    Properties props = TestProps.loadFromFile(args[0]);
    +    ContinuousEnv env = new ContinuousEnv(props);
    --- End diff --
    
    I like ContinuousEnv


> Accumulo test benchmarks should go in a separate git repo
> ---------------------------------------------------------
>
>                 Key: ACCUMULO-4510
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4510
>             Project: Accumulo
>          Issue Type: Task
>            Reporter: Christopher Tubbs
>            Assignee: Mike Walch
>            Priority: Minor
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Benchmarks should be version-independent, and/or work across versions to be meaningful.
The tests/benchmark scripts which accompany Accumulo releases are also not necessarily tested
or even functional. They should be shipped separately, if we continue to maintain them at
all. I actually don't even think they need to be released. They can be continuously updated
as needed for developer testing/benchmarking, without necessarily releasing (similar with
examples, and website documentation).
> We can request a new git repo easily at https://reporeq.apache.org



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message