accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (ACCUMULO-3281) Leverage SortedMap methods in Tablet methods that iterate over Key/Values
Date Sat, 21 Jan 2017 22:15:26 GMT

     [ https://issues.apache.org/jira/browse/ACCUMULO-3281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Josh Elser resolved ACCUMULO-3281.
----------------------------------
       Resolution: Won't Fix
    Fix Version/s:     (was: 2.0.0)

These methods were broken out of Tablet a while back and put into TabletData. The original
intent of this change request is lost.

> Leverage SortedMap methods in Tablet methods that iterate over Key/Values
> -------------------------------------------------------------------------
>
>                 Key: ACCUMULO-3281
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3281
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: tserver
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Minor
>
> Noticed the following methods in Tablet could be a little more efficient:
> * {{lookupLogEntries(KeyExtent, SortedMap)}}
> * {{lookupScanFiles(KeyExtent, SortedMap, VolumeManager)}}
> * {{lookupFlushID(KeyExtent, SortedMap)}}
> * {{lookupCompactID(KeyExtent, SortedMap)}}
> Each of these methods iterates over the SortedMap of KeyValues which a collection of
columns from this tablet's row in {{metadata}}.
> Some of them iterate over the "headMap" to consume keys they don't care about. Others
always iterate over all of the values in the map. All of these methods only care about some
sequence of values in the map and could use methods like {{tailMap}} or {{subMap}}.
> I doubt there would be a noticeable improvement (since the number of key-value pairs
for a tablet shouldn't ever really be more than a hundred or so), but since we already have
the sorted structure, it would be nice to use it.
> It would also be nice to write some unit tests for these methods while we're at it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message