accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-4540) '_devtools/git-hooks/post-commit' does not fail gracefully on missing the local branch 'asf-site'
Date Tue, 20 Dec 2016 21:39:58 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-4540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765312#comment-15765312
] 

Christopher Tubbs commented on ACCUMULO-4540:
---------------------------------------------

FWIW, the message is produced by the built-in {{die}} function sourced from {{git-sh-setup}},
rather than doing too much custom message logging ourselves.

If we improve the error message, it should still be a fatal error message, but how does the
following sound: "fatal: asf-site is not a branch; will not update it with the latest commit"?

Also, you should symlink it instead of copying it... that way you'll get the benefits of updates
to the repo's master branch.

> '_devtools/git-hooks/post-commit' does not fail gracefully on missing the local branch
'asf-site'
> -------------------------------------------------------------------------------------------------
>
>                 Key: ACCUMULO-4540
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4540
>             Project: Accumulo
>          Issue Type: Bug
>          Components: website
>            Reporter: Josh Elser
>            Assignee: Christopher Tubbs
>            Priority: Trivial
>
> I did a fresh clone of the accumulo-website.git repository and copied the post-commit
hook into {{.git/hooks}}. Upon making my first commit, it failed:
> {{fatal: asf-site is not a branch}}
> Would be nice if we caught it when asf-site doesn't exist locally and give a better error
message.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message