Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 67044200B89 for ; Wed, 21 Sep 2016 16:50:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 65B0B160ABC; Wed, 21 Sep 2016 14:50:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C2FAE160ADE for ; Wed, 21 Sep 2016 16:50:21 +0200 (CEST) Received: (qmail 93937 invoked by uid 500); 21 Sep 2016 14:50:20 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 93867 invoked by uid 99); 21 Sep 2016 14:50:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Sep 2016 14:50:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 8CCD32C2A68 for ; Wed, 21 Sep 2016 14:50:20 +0000 (UTC) Date: Wed, 21 Sep 2016 14:50:20 +0000 (UTC) From: "Will Murnane (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (ACCUMULO-4468) accumulo.core.data.Key.equals(Key, PartialKey) improvement MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 21 Sep 2016 14:50:22 -0000 Will Murnane created ACCUMULO-4468: -------------------------------------- Summary: accumulo.core.data.Key.equals(Key, PartialKey) improvement Key: ACCUMULO-4468 URL: https://issues.apache.org/jira/browse/ACCUMULO-4468 Project: Accumulo Issue Type: Improvement Components: core Affects Versions: 1.8.0 Reporter: Will Murnane Priority: Trivial In the Key.equals(Key, PartialKey) overload, the current method compares starting at the beginning of the key, and works its way toward the end. This functions correctly, of course, but one of the typical uses of this method is to compare adjacent rows to break them into larger chunks. For example, accumulo.core.iterators.Combiner repeatedly calls this method with subsequent pairs of keys. I have a patch which reverses the comparison order. That is, if the method is called with ROW_COLFAM_COLQUAL_COLVIS, it will compare visibility, cq, cf, and finally row. This (marginally) improves the speed of comparisons in the relatively common case where only the last part is changing, with less complex code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)