Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 72A3E200B95 for ; Tue, 13 Sep 2016 00:16:26 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 7101A160AD6; Mon, 12 Sep 2016 22:16:26 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B6707160AB8 for ; Tue, 13 Sep 2016 00:16:25 +0200 (CEST) Received: (qmail 53087 invoked by uid 500); 12 Sep 2016 21:45:36 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 53051 invoked by uid 99); 12 Sep 2016 21:45:36 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Sep 2016 21:45:36 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id A4DA92C1B7B for ; Mon, 12 Sep 2016 21:45:21 +0000 (UTC) Date: Mon, 12 Sep 2016 21:45:21 +0000 (UTC) From: "Christopher Tubbs (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (ACCUMULO-4391) Source deepcopies cannot be used safely in separate threads in tserver MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 12 Sep 2016 22:16:26 -0000 [ https://issues.apache.org/jira/browse/ACCUMULO-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Tubbs resolved ACCUMULO-4391. ----------------------------------------- Resolution: Fixed Closing this. I created ACCUMULO-4455 for more tests. Please comment on or amend that issue to suggest specific test cases which could/should be added, so folks don't have to mine them from this discussion or the PR. Thanks :) > Source deepcopies cannot be used safely in separate threads in tserver > ---------------------------------------------------------------------- > > Key: ACCUMULO-4391 > URL: https://issues.apache.org/jira/browse/ACCUMULO-4391 > Project: Accumulo > Issue Type: Bug > Components: core > Affects Versions: 1.6.5 > Reporter: Ivan Bella > Assignee: Ivan Bella > Fix For: 1.6.6, 1.7.3, 1.8.1, 2.0.0 > > Original Estimate: 24h > Time Spent: 16h 50m > Remaining Estimate: 7h 10m > > We have iterators that create deep copies of the source and use them in separate threads. As it turns out this is not safe and we end up with many exceptions, mostly down in the ZlibDecompressor library. Curiously if you turn on the data cache for the table being scanned then the errors disappear. > After much hunting it turns out that the real bug is in the BoundedRangeFileInputStream. The read() method therein appropriately synchronizes on the underlying FSDataInputStream, however the available() method does not. Adding similar synchronization on that stream fixes the issues. On a side note, the available() call is only invoked within the hadoop CompressionInputStream for use in the getPos() call. That call does not appear to actually be used at least in this context. -- This message was sent by Atlassian JIRA (v6.3.4#6332)