accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Will Murnane (JIRA)" <j...@apache.org>
Subject [jira] [Created] (ACCUMULO-4468) accumulo.core.data.Key.equals(Key, PartialKey) improvement
Date Wed, 21 Sep 2016 14:50:20 GMT
Will Murnane created ACCUMULO-4468:
--------------------------------------

             Summary: accumulo.core.data.Key.equals(Key, PartialKey) improvement
                 Key: ACCUMULO-4468
                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4468
             Project: Accumulo
          Issue Type: Improvement
          Components: core
    Affects Versions: 1.8.0
            Reporter: Will Murnane
            Priority: Trivial


In the Key.equals(Key, PartialKey) overload, the current method compares starting at the beginning
of the key, and works its way toward the end. This functions correctly, of course, but one
of the typical uses of this method is to compare adjacent rows to break them into larger chunks.
For example, accumulo.core.iterators.Combiner repeatedly calls this method with subsequent
pairs of keys.

I have a patch which reverses the comparison order. That is, if the method is called with
ROW_COLFAM_COLQUAL_COLVIS, it will compare visibility, cq, cf, and finally row. This (marginally)
improves the speed of comparisons in the relatively common case where only the last part is
changing, with less complex code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message