accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <>
Subject [jira] [Commented] (ACCUMULO-4443) Make performance test category usage consistent with other categories
Date Thu, 08 Sep 2016 03:06:20 GMT


Christopher Tubbs commented on ACCUMULO-4443:

I also think profiles are valuable for command-line brevity. I just don't think its necessary
to pre-define a lot of them in the POM when users can mix-and-match their own, based on their
individual use cases (that's what {{settings.xml}} is for). It bloats the pom quite a bit,
and it's very subjective which specific combinations should be pre-defined, and I think that's
best left to the user.

The profiles you had created were largely unnecessary after some of the simplification I did.
I had thought you had agreed with me on that, but I can't find a record of that discussion
anywhere. I apologize if I misunderstood.

The sunny one already existed, so, preserving that one makes sense for backwards-compatibility,
but the file doesn't refer to the profile, only the category, like the others.

I share your interest in brevity, though, but I'd like to find a better way to achieve that,
if we can. For example, pursuing support for using category patterns in surefire/failsafe,
just like they currently support with {{-Dtest=}}, assuming they don't already support that
(I haven't tried yet).

> Make performance test category usage consistent with other categories
> ---------------------------------------------------------------------
>                 Key: ACCUMULO-4443
>                 URL:
>             Project: Accumulo
>          Issue Type: Sub-task
>          Components: test
>    Affects Versions: 1.8.0
>            Reporter: Christopher Tubbs
>            Assignee: Christopher Tubbs
>            Priority: Minor
>             Fix For: 1.8.0
>          Time Spent: 20m
>  Remaining Estimate: 0h
> Currently, performance tests categories are excluded by default in 1.8+ branches.
> This is unexpected when trying to do a full build.
> It is also documented as being triggered differently than other test categories, even
though it is using the same basic categorization method.
> For consistency, we should include all tests by default, and update the performance tests
documentation to match how the other test categories are documented and used.

This message was sent by Atlassian JIRA

View raw message