Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E7008200B73 for ; Mon, 29 Aug 2016 17:42:21 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E58A6160AC8; Mon, 29 Aug 2016 15:42:21 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5F700160AB8 for ; Mon, 29 Aug 2016 17:42:21 +0200 (CEST) Received: (qmail 29895 invoked by uid 500); 29 Aug 2016 15:42:20 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 29784 invoked by uid 99); 29 Aug 2016 15:42:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Aug 2016 15:42:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 704BA2C0151 for ; Mon, 29 Aug 2016 15:42:20 +0000 (UTC) Date: Mon, 29 Aug 2016 15:42:20 +0000 (UTC) From: "Josh Elser (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ACCUMULO-4428) GC does not delete WAL files belonging to dead tservers MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 29 Aug 2016 15:42:22 -0000 [ https://issues.apache.org/jira/browse/ACCUMULO-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446214#comment-15446214 ] Josh Elser commented on ACCUMULO-4428: -------------------------------------- Argh, yes, this looks rather bad. If I'm understanding it correctly, this means that we'll *never* remove WALs for old servers. That's super bad. > GC does not delete WAL files belonging to dead tservers > ------------------------------------------------------- > > Key: ACCUMULO-4428 > URL: https://issues.apache.org/jira/browse/ACCUMULO-4428 > Project: Accumulo > Issue Type: Bug > Affects Versions: 1.7.2 > Reporter: Adam J Shook > Priority: Blocker > Fix For: 1.7.3, 1.8.1 > > > The GarbageCollectWriteAheadLogs uses a Map to track when it had first seen a dead tserver, waiting an hour before deleting the files. However, a new instance of this class is re-created during each run of the SimpleGarbageCollector, causing the state of the dead tservers to be lost. All of the WAL files belonging to a dead tserver will never be removed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)