Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 94284200B97 for ; Sat, 27 Aug 2016 15:52:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9302E160AA6; Sat, 27 Aug 2016 13:52:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D92DA160AC5 for ; Sat, 27 Aug 2016 15:52:21 +0200 (CEST) Received: (qmail 69331 invoked by uid 500); 27 Aug 2016 13:52:21 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 69205 invoked by uid 99); 27 Aug 2016 13:52:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 27 Aug 2016 13:52:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D2AC12C0157 for ; Sat, 27 Aug 2016 13:52:20 +0000 (UTC) Date: Sat, 27 Aug 2016 13:52:20 +0000 (UTC) From: "Mario Pastorelli (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (ACCUMULO-4376) Introduce a Builders for "data" classes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 27 Aug 2016 13:52:22 -0000 [ https://issues.apache.org/jira/browse/ACCUMULO-4376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15441586#comment-15441586 ] Mario Pastorelli edited comment on ACCUMULO-4376 at 8/27/16 1:52 PM: --------------------------------------------------------------------- There are a lot of important things in ACCUMULO-2589 but nothing related to how Keys and other structures are created. Are you talking about some specific task/comment of that JIRA? was (Author: melrief): Ther are a lot of important things in ACCUMULO-2589 but nothing related to how Keys and other structures are created. Are you talking about some specific task/comment of that JIRA? > Introduce a Builders for "data" classes > --------------------------------------- > > Key: ACCUMULO-4376 > URL: https://issues.apache.org/jira/browse/ACCUMULO-4376 > Project: Accumulo > Issue Type: Improvement > Components: client > Reporter: Josh Elser > Fix For: 2.0.0 > > > In looking at ACCUMULO-4375, I was a little frustrated at how we have 3x constructors than Key really provides just to support {{byte[]}}, {{Text}}, and {{CharSequence}} arguments. Additionally, the {{copy}} argument forces the user to use the most specific (most arguments) constructor if they want to avoid the copy. This makes constructing a Key from just a row while avoiding a copy very pedantic. > I think a KeyBuilder (or KeyFactory) class would be a big usability benefit and reduce the amount of code that clients have to write to most efficiently construct Keys. -- This message was sent by Atlassian JIRA (v6.3.4#6332)