Return-Path: <notifications-return-36631-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 7A7B2200B71
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed, 17 Aug 2016 03:21:22 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 79566160ABC; Wed, 17 Aug 2016 01:21:22 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id CAF16160AA8
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 17 Aug 2016 03:21:21 +0200 (CEST)
Received: (qmail 76582 invoked by uid 500); 17 Aug 2016 01:21:20 -0000
Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:notifications-help@accumulo.apache.org>
List-Unsubscribe: <mailto:notifications-unsubscribe@accumulo.apache.org>
List-Post: <mailto:notifications@accumulo.apache.org>
List-Id: <notifications.accumulo.apache.org>
Reply-To: jira@apache.org
Delivered-To: mailing list notifications@accumulo.apache.org
Received: (qmail 76154 invoked by uid 99); 17 Aug 2016 01:21:20 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Aug 2016 01:21:20 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id A0D392C02A4
	for <notifications@accumulo.apache.org>; Wed, 17 Aug 2016 01:21:20 +0000 (UTC)
Date: Wed, 17 Aug 2016 01:21:20 +0000 (UTC)
From: "Christopher Tubbs (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.12966294.1462822579000.324794.1471396880655@Atlassian.JIRA>
In-Reply-To: <JIRA.12966294.1462822579000@Atlassian.JIRA>
References: <JIRA.12966294.1462822579000@Atlassian.JIRA> <JIRA.12966294.1462822579055@arcas>
Subject: [jira] [Commented] (ACCUMULO-4307) semver compliance maven plugin
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Wed, 17 Aug 2016 01:21:22 -0000


    [ https://issues.apache.org/jira/browse/ACCUMULO-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423715#comment-15423715 ] 

Christopher Tubbs commented on ACCUMULO-4307:
---------------------------------------------

Nice change! Will need to clean up some stuffs (use pluginManagement for version, add mini, get rid of spaces in execution IDs, etc.), but overall, looks like it'll be a nice sanity check. We could add this to the release:prepare goal for checking during release candidate creation. We'll definitely want this in the 2.0 API module, too.

> semver compliance maven plugin
> ------------------------------
>
>                 Key: ACCUMULO-4307
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4307
>             Project: Accumulo
>          Issue Type: New Feature
>          Components: build
>            Reporter: Dave Marion
>            Assignee: Christopher Tubbs
>             Fix For: 1.6.6, 1.7.3, 1.8.1
>
>         Attachments: ACCUMULO-4307-1.patch
>
>
> Found https://siom79.github.io/japicmp/MavenPlugin.html today and tested it out. Was wondering what thoughts are for incorporating this into the build. I tested it on 1.6.6-SNAPSHOT by dropping the following into the test pom file:
> {noformat}
>     <profile>
>       <id>semver-compliance</id>
>       <build>
>         <plugins>
>           <plugin>
>             <groupId>com.github.siom79.japicmp</groupId>
>             <artifactId>japicmp-maven-plugin</artifactId>
>             <version>0.7.2</version>
>             <executions>
>               <execution>
>                 <id>client compliance</id>
>                 <goals>
>                   <goal>cmp</goal>
>                 </goals>
>                 <phase>verify</phase>
>                 <configuration>
>                   <oldVersion>
>                     <dependency>
>                       <groupId>org.apache.accumulo</groupId>
>                       <artifactId>accumulo-core</artifactId>
>                       <version>1.6.5</version>
>                       <type>jar</type>
>                     </dependency>
>                   </oldVersion>
>                   <newVersion>
>                     <dependency>
>                       <groupId>org.apache.accumulo</groupId>
>                       <artifactId>accumulo-core</artifactId>
>                       <version>${project.version}</version>
>                       <type>jar</type>
>                     </dependency>
>                   </newVersion>
>                   <parameter>
>                     <includes>
>                       <include>org.apache.accumulo.core.client</include>
>                       <include>org.apache.accumulo.core.data</include>
>                       <include>org.apache.accumulo.core.security</include>
>                     </includes>
>                     <excludes>
>                       <exclude>*crypto*</exclude>
>                       <exclude>*impl*</exclude>
>                       <exclude>*thrift*</exclude>
>                     </excludes>
>                     <accessModifier>protected</accessModifier>
>                     breakBuildBasedOnSemanticVersioning>true</breakBuildBasedOnSematicVersioning>
>                     <onlyModified>true</onlyModified>
>                   </parameter>
>                 </configuration>
>               </execution>
>             </executions>
>           </plugin>
>         </plugins>
>       </build>
>     </profile>
> {noformat}
>  I tried getting the previous release version number using the build-helper-maven-plugin, but it found the wrong version. If we use this we would also have to include an execution for minicluster and determine whether or not we want to use the reporting feature of the plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)