accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <>
Subject [jira] [Commented] (ACCUMULO-4425) VolumeIT.testDirtyReplaceVolumes fails
Date Sun, 28 Aug 2016 21:01:21 GMT


Josh Elser commented on ACCUMULO-4425:

bq. The label was the easiest first pass I thought of. I could simplify it with a boolean
conditional on the outer loop. I'm more concerned about the strategy of handling this in the
test itself than the specific implementation.

Yup, I understand and agree with you completely.

bq. I agree with the concern about runtime issues. That's why I put it up for review as a
PR. I'm concerned we're not properly handling this internally in the WalStateManager. But,
I'm also wondering if this is something that can only happen in the test. The thing is...
in the dirty shutdown case, I'm not actually sure why these states persist. Perhaps it's just
because the ephemeral ZK nodes haven't timed out yet? Maybe it's not something to be concerned
about in a real system and is only an artifact of the test. At the very least, it's clear
from the workaround that they will eventually resolve themselves, and maybe that's sufficient
for a running system? This part of our code is hard to reason about... because there aren't
a lot of comments explaining how the design is supposed to work.

I'm sure [~kturner]

> VolumeIT.testDirtyReplaceVolumes fails
> --------------------------------------
>                 Key: ACCUMULO-4425
>                 URL:
>             Project: Accumulo
>          Issue Type: Bug
>            Reporter: Christopher Tubbs
>            Assignee: Christopher Tubbs
>            Priority: Blocker
>             Fix For: 1.8.0
>          Time Spent: 10m
>  Remaining Estimate: 0h
> *Error Message*
> {code}
> Unexpected volume file:/var/lib/jenkins/workspace/Accumulo-1.8-ITs-failures/test/target/mini-tests/org.apache.accumulo.test.VolumeIT_testDirtyReplaceVolumes/volumes/v1/wal/
> {code}
> *Stacktrace*
> {code}
> java.lang.AssertionError: Unexpected volume file:/var/lib/jenkins/workspace/Accumulo-1.8-ITs-failures/test/target/mini-tests/org.apache.accumulo.test.VolumeIT_testDirtyReplaceVolumes/volumes/v1/wal/
> 	at org.apache.accumulo.test.VolumeIT.verifyVolumesUsed(
> 	at org.apache.accumulo.test.VolumeIT.testReplaceVolume(
> 	at org.apache.accumulo.test.VolumeIT.testDirtyReplaceVolumes(
> {code}

This message was sent by Atlassian JIRA

View raw message