accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <>
Subject [jira] [Commented] (ACCUMULO-4376) Introduce a Builders for "data" classes
Date Sun, 28 Aug 2016 16:24:20 GMT


Christopher Tubbs commented on ACCUMULO-4376:

[~melrief], I think you misunderstand. That branch contains several different experimental
things I've been playing with. I wouldn't recommend starting from the whole branch (not sure
it even compiles or merges right now). I only thought the Key builder in it might be useful
as one possible pattern you could follow for all the data classes.

That branch is entirely a playground of ideas I've been thinking about. Nothing is concrete
or decided. If you want to use something from it, you can. If you'd prefer a different design,
that's fine too.

> Introduce a Builders for "data" classes
> ---------------------------------------
>                 Key: ACCUMULO-4376
>                 URL:
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: client
>            Reporter: Josh Elser
>             Fix For: 2.0.0
> In looking at ACCUMULO-4375, I was a little frustrated at how we have 3x constructors
than Key really provides just to support {{byte[]}}, {{Text}}, and {{CharSequence}} arguments.
Additionally, the {{copy}} argument forces the user to use the most specific (most arguments)
constructor if they want to avoid the copy. This makes constructing a Key from just a row
while avoiding a copy very pedantic.
> I think a KeyBuilder (or KeyFactory) class would be a big usability benefit and reduce
the amount of code that clients have to write to most efficiently construct Keys.

This message was sent by Atlassian JIRA

View raw message