accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Marion (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-4376) Introduce a Builders for "data" classes
Date Sat, 27 Aug 2016 15:28:20 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-4376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15441771#comment-15441771
] 

Dave Marion commented on ACCUMULO-4376:
---------------------------------------

Nothing specific, just looking for proposed changes that may affect the builder classes. I
am of the opinion that we should not deter someone from contributing a piece of work because
it may change in the future. If it makes sense, doesn't conflict with future plans, and you
are willing to do the work, then let's get it done. I am also of the opinion that we can also
introduce API changes slowly over time instead of an all new API in a major release.

> Introduce a Builders for "data" classes
> ---------------------------------------
>
>                 Key: ACCUMULO-4376
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4376
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: client
>            Reporter: Josh Elser
>             Fix For: 2.0.0
>
>
> In looking at ACCUMULO-4375, I was a little frustrated at how we have 3x constructors
than Key really provides just to support {{byte[]}}, {{Text}}, and {{CharSequence}} arguments.
Additionally, the {{copy}} argument forces the user to use the most specific (most arguments)
constructor if they want to avoid the copy. This makes constructing a Key from just a row
while avoiding a copy very pedantic.
> I think a KeyBuilder (or KeyFactory) class would be a big usability benefit and reduce
the amount of code that clients have to write to most efficiently construct Keys.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message