accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-4376) Introduce a Builders for "data" classes
Date Mon, 18 Jul 2016 23:16:20 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-4376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383271#comment-15383271
] 

Christopher Tubbs commented on ACCUMULO-4376:
---------------------------------------------

Yeah,i haven't added this yet, I was just thinking it'd be good to coordinate, and maybe we
skip a 1.9 release in favor of a 2.0 containing these additions. If it means this gets committed
first and I move the new classes into the API module before release, that'd work for me. The
only real change is that the API module won't have a hadoop dependency, so no Text factories
in the new class. At least, that's what I was thinking.

> Introduce a Builders for "data" classes
> ---------------------------------------
>
>                 Key: ACCUMULO-4376
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4376
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: client
>            Reporter: Josh Elser
>             Fix For: 1.9.0
>
>
> In looking at ACCUMULO-4375, I was a little frustrated at how we have 3x constructors
than Key really provides just to support {{byte[]}}, {{Text}}, and {{CharSequence}} arguments.
Additionally, the {{copy}} argument forces the user to use the most specific (most arguments)
constructor if they want to avoid the copy. This makes constructing a Key from just a row
while avoiding a copy very pedantic.
> I think a KeyBuilder (or KeyFactory) class would be a big usability benefit and reduce
the amount of code that clients have to write to most efficiently construct Keys.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message