accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-4374) ChangeSecret tool can't accept password input
Date Thu, 21 Jul 2016 15:07:21 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-4374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387862#comment-15387862
] 

Josh Elser commented on ACCUMULO-4374:
--------------------------------------

Any chance I could get you to do a second patch/pull-request for 1.7, [~milleruntime]? I got
your changes against master working on 1.8, but they did not apply on 1.7 (and it looked significantly
different). I can handle merging the two changesets into the appropriate branches then.

> ChangeSecret tool can't accept password input
> ---------------------------------------------
>
>                 Key: ACCUMULO-4374
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4374
>             Project: Accumulo
>          Issue Type: Bug
>          Components: shell
>            Reporter: Michael Miller
>            Assignee: Michael Miller
>              Labels: newbie
>             Fix For: 1.7.3, 1.8.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Changes to o.a.a.shell.Shell have broken the ChangeSecret tool. When running o.a.a.server.util.ChangeSecret
using the bin/accumulo script, another thread running the Shell will also have an open input
stream interfering with the input of the password. This is due to the ServiceLoader creating
an instance of the Shell using the no arg constructor, which creates an instance of the jline
ConsoleReader. 
> There are two options to fix this bug:
>   1. Make the no-arg constructor in the Shell do less work. (this should be
> easy, because it's only called by Shell.main, and main can just pass the
> parameters that the no-arg constructor was assuming)
>   2. Move the KeywordExecutable stuffs for Shell into a minimal
> launcher/factory class for Shell; see **/MasterExecutable.java for another
> case where I had to do this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message